<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118862/">https://git.reviewboard.kde.org/r/118862/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Липень 10th, 2014, 9:34 після полудня UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where do the fictionbook icons come from? Is something you did?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Meanwhile i've commited the other changes for icons</p></pre>
</blockquote>
<p>On Липень 11th, 2014, 7:46 до полудня UTC, <b>Yuri Chornoivan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Taken from this topic on the forum:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://www.the-ebook.org/forum/viewtopic.php?t=3391&sid=c7d8b99d1b6efae43a11f1c6e9467df3</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have made an SVG version of 32x32 icon (attached, can do for other resolutions as well).</p></pre>
</blockquote>
<p>On Липень 14th, 2014, 6:04 після полудня UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's the copyright/trademark stuff of this? Are we sure we can use it freely?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">An email sent to the original author to clear up the licensing issues. As it is some what different problem, this RR can be closed now as partially submitted. The RR for FB2 icons will be resubmitted as soon as the licensing problems are solved.</p></pre>
<br />
<p>- Yuri</p>
<br />
<p>On Липень 11th, 2014, 7:46 до полудня UTC, Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Липень 11, 2014, 7:46 до полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336530">336530</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use the available icons from Oxygen for the Tools actions. Add "official" FictionBook icons for the backends configuration window.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works as expected for git/master.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(4fe3877)</span></li>
<li>generators/fictionbook/generator_fb.cpp <span style="color: grey">(466fb72)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(9073139)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118862/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/10e48f57-ec32-49a8-ae3f-52c757695aa2__hi16-app-okular-fb2.png">FB2 16x16 icon</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/53218660-0fd5-4231-8440-e89d0f577cf5__hi32-app-okular-fb2.png">FB2 32x32 icon</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/c648c801-f3b9-4caf-b3a1-fbf03050f13e__hi48-app-okular-fb2.png">FB2 48x48 icon</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/11/9e5e2b36-b020-46bd-aafb-a53b211b9df0__hi32-app-okular-fb2.svg">SVG version for 32x32 icon</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>