[Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

[Saheb Preet Singh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 8:29 a.m.)


Review request for Okular.


Changes
-------

I think playpause action should be declared in part.cpp as it is required to be added to action collection as with erase drawing action. The previous diff is crashing okular as the action was not added to the action collection previously.

corrected the above stated issues.


Bugs: 328125
    http://bugs.kde.org/show_bug.cgi?id=328125


Repository: okular


Description
-------

Okular don't have any play pause button in the presentation mode.

Implemented a playpause action in the action collection in part.cpp.

Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h

In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon

When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button.


Diffs (updated)
-----

  part.cpp 88e2c41 
  ui/presentationwidget.h c63e119 
  ui/presentationwidget.cpp 1b63e2f 

Diff: https://git.reviewboard.kde.org/r/115072/diff/


Testing
-------

tested on local machine, working as desired.


Thanks,

Saheb Preet Singh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140129/de10f1cf/attachment.html>