[Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

Albert Astals Cid aacid at kde.org
Mon Jan 27 21:43:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review48419
-----------------------------------------------------------



ui/presentationwidget.cpp
<https://git.reviewboard.kde.org/r/115072/#comment34243>

    Do you need this?



ui/presentationwidget.cpp
<https://git.reviewboard.kde.org/r/115072/#comment34242>

    Why this?


- Albert Astals Cid


On Jan. 27, 2014, 9:41 a.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115072/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 9:41 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328125
>     http://bugs.kde.org/show_bug.cgi?id=328125
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular don't have any play pause button in the presentation mode.
> 
> Implemented a playpause action in the action collection in part.cpp.
> 
> Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h
> 
> In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon
> 
> When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button.
> 
> 
> Diffs
> -----
> 
>   ui/presentationwidget.cpp 1b63e2f 
>   ui/presentationwidget.h c63e119 
> 
> Diff: https://git.reviewboard.kde.org/r/115072/diff/
> 
> 
> Testing
> -------
> 
> tested on local machine, working as desired.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140127/6460f717/attachment.html>


More information about the Okular-devel mailing list