[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4485
> > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485>
> >
> >     Can you explain why the need for a timer?

This is because, in scroll mode, user just moves their mouse a little bit and then does nothing.  The screen will automatically scroll until user exits scroll mode (by another mouse click).

In order to let the screen scroll duratively, you will need a timer.


> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2307
> > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2307>
> >
> >     Since you're repeating these blocks over and over you may want to add it into a quick function maybe, so that if in the future we need to change something we don't mistakingly forget one of the places.

        bool middlePressZooms();
        bool middlePressScrolls();


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
-----------------------------------------------------------


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
>     http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140128/c2f08d05/attachment.html>