[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.h, line 221
> > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240732#file240732line221>
> >
> >     missing "r" in Scoll

OK.  But slotAutoScoll() is also missing a "r".  I have fixed that also.


> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4497
> > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4497>
> >
> >     repaint is a bit bad, does update work?

repaint is unnecessary.  I have fixed that.


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
-----------------------------------------------------------


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
>     http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140128/30bf67b9/attachment-0001.html>