[Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review50772
-----------------------------------------------------------


Please have a look at http://quickgit.kde.org/?p=okular.git&a=commit&h=9cbe17dbb92c5ed61cc111f4be894c37bb3ef630 for the changes that i would like wanted to request but since Feature Freeze is this week i did myself. If you disagree with something or don't understand something please do not hesitate to ask.

- Albert Astals Cid


On Feb. 24, 2014, 10:30 p.m., Saheb Preet Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115072/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:30 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328125
>     http://bugs.kde.org/show_bug.cgi?id=328125
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular don't have any play pause button in the presentation mode.
> 
> Implemented a playpause action in the action collection in part.cpp.
> 
> Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h
> 
> In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon
> 
> When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button.
> 
> 
> Diffs
> -----
> 
>   part.cpp 283e91a 
>   ui/presentationwidget.h c63e119 
>   ui/presentationwidget.cpp 1b63e2f 
> 
> Diff: https://git.reviewboard.kde.org/r/115072/diff/
> 
> 
> Testing
> -------
> 
> tested on local machine, working as desired.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140224/6dd1dc7b/attachment.html>