<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115072/">https://git.reviewboard.kde.org/r/115072/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please have a look at http://quickgit.kde.org/?p=okular.git&a=commit&h=9cbe17dbb92c5ed61cc111f4be894c37bb3ef630 for the changes that i would like wanted to request but since Feature Freeze is this week i did myself. If you disagree with something or don't understand something please do not hesitate to ask.</pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On February 24th, 2014, 10:30 p.m. UTC, Saheb Preet Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Saheb Preet Singh.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2014, 10:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328125">328125</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okular don't have any play pause button in the presentation mode.
Implemented a playpause action in the action collection in part.cpp.
Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h
In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon
When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested on local machine, working as desired.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.cpp <span style="color: grey">(283e91a)</span></li>
<li>ui/presentationwidget.h <span style="color: grey">(c63e119)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(1b63e2f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115072/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>