[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113973/
-----------------------------------------------------------

(Updated Feb. 23, 2014, 8:59 p.m.)


Review request for Okular.


Changes
-------

This one should do the trick:
* removed debug info label
* added code to disable the feature in nontiled backends
* cleanup the variable declaration


Repository: okular


Description
-------

I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.

The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.

The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.

So the remaining question is, what is the status of this:
 core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?


Diffs (updated)
-----

  CMakeLists.txt 63d2922 
  conf/okular.kcfg f954c9a 
  part.rc 0b9cee5 
  ui/magnifierview.h PRE-CREATION 
  ui/magnifierview.cpp PRE-CREATION 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 7c7f785 

Diff: https://git.reviewboard.kde.org/r/113973/diff/


Testing
-------


Thanks,

Michal Humpula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140223/ef88e265/attachment.html>