[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Michal Humpula]

> On Feb. 23, 2014, 5:24 p.m., Albert Astals Cid wrote:
> > ui/magnifierview.cpp, line 35
> > <https://git.reviewboard.kde.org/r/113973/diff/5/?file=245561#file245561line35>
> >
> >     This means we are zooming at 1000% right? It's a bit weird since i can say zoom up to 1600% in the page and then the magnifier view gives me less zoom than the one i have :D
> >     
> >     Not sure how to fix this thought or if it matters at all.

Yes, but if you zoom even more, you will be inspecting something smaller then one glyf, which is totaly useless, at least for my usage. The main reason for me to have is to inspect kerning and for that I need to see few chars in that window.


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113973/#review50601
-----------------------------------------------------------


On Feb. 22, 2014, 6:01 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113973/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 6:01 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
> 
> The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
> 
> The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
> 
> So the remaining question is, what is the status of this:
>  core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
> Is someone working on it?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63d2922 
>   conf/okular.kcfg f954c9a 
>   part.rc 0b9cee5 
>   ui/magnifierview.h PRE-CREATION 
>   ui/magnifierview.cpp PRE-CREATION 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 7c7f785 
> 
> Diff: https://git.reviewboard.kde.org/r/113973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140223/a4208de0/attachment.html>