[Okular-devel] Review Request 119595: Pass the command line options properly when using tabs or unique instances

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119595/#review64020
-----------------------------------------------------------

Ship it!


Not deep review of the code, but the test looks quite complete; from my limited testing I didn't notice regression and the associated bug is fixed.

- Luigi Toscano


On Ago. 3, 2014, 10 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119595/
> -----------------------------------------------------------
> 
> (Updated Ago. 3, 2014, 10 p.m.)
> 
> 
> Review request for Okular and Jonathan Doman.
> 
> 
> Bugs: 334100
>     http://bugs.kde.org/show_bug.cgi?id=334100
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Use a QString to serialize the command line options other than urls to open so it can be easily passed around to every place that opens a new shell or tab or overrides the content in a unique instance.
> 
> Maybe there's something the autotest does not test but it'd be a cornercase, I'd like to have this for 4.14
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 61e2113 
>   shell/okular_main.h PRE-CREATION 
>   shell/okular_main.cpp PRE-CREATION 
>   shell/shell.h e540054 
>   shell/shell.cpp 55f4f12 
>   shell/shellutils.h 6c0c228 
>   shell/shellutils.cpp 26c6825 
>   tests/CMakeLists.txt 3b3fbdd 
>   tests/mainshelltest.cpp PRE-CREATION 
>   conf/settings.kcfgc 9064d15 
>   core/document.cpp 921a7e8 
>   core/document_p.h aabd192 
>   shell/CMakeLists.txt 521a216 
> 
> Diff: https://git.reviewboard.kde.org/r/119595/diff/
> 
> 
> Testing
> -------
> 
> I have an autotest!
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140807/d8b90a44/attachment-0001.html>