<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119595/">https://git.reviewboard.kde.org/r/119595/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not deep review of the code, but the test looks quite complete; from my limited testing I didn't notice regression and the associated bug is fixed.</p></pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On agosto 3rd, 2014, 10 p.m. CEST, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular and Jonathan Doman.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Ago. 3, 2014, 10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334100">334100</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use a QString to serialize the command line options other than urls to open so it can be easily passed around to every place that opens a new shell or tab or overrides the content in a unique instance.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe there's something the autotest does not test but it'd be a cornercase, I'd like to have this for 4.14</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have an autotest!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/main.cpp <span style="color: grey">(61e2113)</span></li>
<li>shell/okular_main.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/okular_main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/shell.h <span style="color: grey">(e540054)</span></li>
<li>shell/shell.cpp <span style="color: grey">(55f4f12)</span></li>
<li>shell/shellutils.h <span style="color: grey">(6c0c228)</span></li>
<li>shell/shellutils.cpp <span style="color: grey">(26c6825)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(3b3fbdd)</span></li>
<li>tests/mainshelltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/settings.kcfgc <span style="color: grey">(9064d15)</span></li>
<li>core/document.cpp <span style="color: grey">(921a7e8)</span></li>
<li>core/document_p.h <span style="color: grey">(aabd192)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(521a216)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119595/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>