[Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

[Jaydeep Solanki]

> On July 21, 2013, 9:07 p.m., Albert Astals Cid wrote:
> > Jaydeep, can you confirm you are working so that http://bugs.kde.org/attachment.cgi?id=51488 can be correctly seen in a dark colorscheme?
> 
> Jaydeep Solanki wrote:
>     I tried it, with color scheme "Krita-darker" (background colors dark & foreground colors light).
>     Here's how it looks, http://db.tt/iHkjbxN1
>     
>     Am I missing something ?
> 
> Jaydeep Solanki wrote:
>     ok, I can reproduce it now.
> 
> Albert Astals Cid wrote:
>     So Jaydeep do we have a fix? is this fix correct? What should we do regarding this review request?
> 
> Albert Astals Cid wrote:
>     Jaydeep?

I agree with Albert, this isn't a proper fix. There are chances of having black on black!
Just try your patch, with http://bugs.kde.org/attachment.cgi?id=51488, and you'll know what we are trying to say. ( use dark color scheme )

BTW, I don't think making the user switch color schemes just to view a simple epub is the solution. Make him like Okular :)


- Jaydeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review36250
-----------------------------------------------------------


On July 21, 2013, 9:06 p.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109364/
> -----------------------------------------------------------
> 
> (Updated July 21, 2013, 9:06 p.m.)
> 
> 
> Review request for Okular and Jaydeep Solanki.
> 
> 
> Description
> -------
> 
> Instead of just force it to white.
>     
> This must fix bug 306572.
> https://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> This addresses bug 306572.
>     http://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> Diffs
> -----
> 
>   core/textdocumentgenerator.cpp f370ded 
> 
> Diff: http://git.reviewboard.kde.org/r/109364/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130926/a12dda75/attachment.html>