<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109364/">http://git.reviewboard.kde.org/r/109364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2013, 9:07 p.m. IST, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jaydeep, can you confirm you are working so that http://bugs.kde.org/attachment.cgi?id=51488 can be correctly seen in a dark colorscheme?</pre>
</blockquote>
<p>On July 21st, 2013, 9:41 p.m. IST, <b>Jaydeep Solanki</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried it, with color scheme "Krita-darker" (background colors dark & foreground colors light).
Here's how it looks, http://db.tt/iHkjbxN1
Am I missing something ?</pre>
</blockquote>
<p>On July 23rd, 2013, 11:50 a.m. IST, <b>Jaydeep Solanki</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, I can reproduce it now.</pre>
</blockquote>
<p>On August 15th, 2013, 3:55 a.m. IST, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So Jaydeep do we have a fix? is this fix correct? What should we do regarding this review request?</pre>
</blockquote>
<p>On September 26th, 2013, 2:05 a.m. IST, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jaydeep?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Albert, this isn't a proper fix. There are chances of having black on black!
Just try your patch, with http://bugs.kde.org/attachment.cgi?id=51488, and you'll know what we are trying to say. ( use dark color scheme )
BTW, I don't think making the user switch color schemes just to view a simple epub is the solution. Make him like Okular :)</pre>
<br />
<p>- Jaydeep</p>
<br />
<p>On July 21st, 2013, 9:06 p.m. IST, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Jaydeep Solanki.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated July 21, 2013, 9:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of just force it to white.
This must fix bug 306572.
https://bugs.kde.org/show_bug.cgi?id=306572</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306572">306572</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/textdocumentgenerator.cpp <span style="color: grey">(f370ded)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>