[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113973/#review44625
-----------------------------------------------------------


As said in IRC, i'm not really thrilled about this feature, but on the other hand its quite separate from existing code, so it's not that bad, anyway it has a huge blocker you mention in the form of the hack, so you need to first fix that.


ui/magnifierview.cpp
<http://git.reviewboard.kde.org/r/113973/#comment31851>

    hardcoded colors are usually bad, there's nothing in KColorScheme you can use?



ui/magnifierview.cpp
<http://git.reviewboard.kde.org/r/113973/#comment31852>

    this-> is quite un-C++-y please remove



ui/magnifierview.cpp
<http://git.reviewboard.kde.org/r/113973/#comment31853>

    static const int?



ui/magnifierview.cpp
<http://git.reviewboard.kde.org/r/113973/#comment31854>

    This needs i18n


- Albert Astals Cid


On Nov. 20, 2013, 5:53 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113973/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 5:53 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.
> 
> The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.
> 
> The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.
> 
> So the remaining question is, what is the status of this:
>  core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
> Is someone working on it?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 217337f 
>   conf/okular.kcfg deabd07 
>   ui/magnifierview.h PRE-CREATION 
>   ui/magnifierview.cpp PRE-CREATION 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 65967bf 
> 
> Diff: http://git.reviewboard.kde.org/r/113973/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Allow BIG pixmaps
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/20/52c4f894-2286-421e-8025-45027d93524e__01-hack.patch
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131127/adfbf250/attachment.html>