[Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113973/
-----------------------------------------------------------

(Updated Nov. 20, 2013, 5:53 p.m.)


Review request for Okular.


Repository: okular


Description
-------

I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.

The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.

The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.

So the remaining question is, what is the status of this:
 core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?


Diffs
-----

  CMakeLists.txt 217337f 
  conf/okular.kcfg deabd07 
  ui/magnifierview.h PRE-CREATION 
  ui/magnifierview.cpp PRE-CREATION 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: http://git.reviewboard.kde.org/r/113973/diff/


Testing
-------


File Attachments (updated)
----------------

Allow BIG pixmaps
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/20/52c4f894-2286-421e-8025-45027d93524e__01-hack.patch


Thanks,

Michal Humpula

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20131120/cfae9541/attachment.html>