[Okular-devel] Review Request 109632: Annotation eraser

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109632/#review29738
-----------------------------------------------------------


So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo annotations code gets merged. I'd suggest you have a look at it and try to find out how you'd apply your changes on top of it.


ui/pageviewannotator.cpp
<http://git.reviewboard.kde.org/r/109632/#comment22135>

    const


- Albert Astals Cid


On March 21, 2013, 1:26 a.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109632/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 1:26 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Prerequisites: Please read till the end!
> 
> This introduces a new annotation tool: "Eraser".
> 
> The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.).
> 
> However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved.
> This is what it looks like: http://bedahr.org/eraser.ogv
> 
> 
> Example tool configuration for your tools.xml (not included in patch):
> 
> <tool id="15" name="Eraser" pixmap="tool-eraser-okular">
>    <tooltip>Eraser</tooltip>
>    <engine type="Eraser" />
>    <shortcut>7</shortcut>
> </tool>
> 
> The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewannotator.cpp 7bd7496 
> 
> Diff: http://git.reviewboard.kde.org/r/109632/diff/
> 
> 
> Testing
> -------
> 
> While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change.
> I hope we can resume the discussion about possible improvements here.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130322/3001339e/attachment-0001.html>