[Okular-devel] Review Request 109632: Annotation eraser

[Albert Astals Cid]

> On March 21, 2013, 11:29 p.m., Albert Astals Cid wrote:
> > It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially?
> 
> Peter Grasch wrote:
>     For example:
>     1. Correct a shoddily drawn shape
>     2. Remove an accidentally drawn line over something else without having to re-do what's below
>     3. Change an "I" to an "i" :)
>     4. ...
>     
>     Also, it much more directly mirrors what a user will probably expect from an "eraser" tool.
>     
>     FWIW, these review requests are a direct result of me trying to switch from Xournal to Okular for taking notes in class. I implemented this because I thought it would be a nice feature to use - not a nice one to implement.

So *you* are the use case, that works for me.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109632/#review29667
-----------------------------------------------------------


On March 21, 2013, 1:26 a.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109632/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 1:26 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Prerequisites: Please read till the end!
> 
> This introduces a new annotation tool: "Eraser".
> 
> The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.).
> 
> However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved.
> This is what it looks like: http://bedahr.org/eraser.ogv
> 
> 
> Example tool configuration for your tools.xml (not included in patch):
> 
> <tool id="15" name="Eraser" pixmap="tool-eraser-okular">
>    <tooltip>Eraser</tooltip>
>    <engine type="Eraser" />
>    <shortcut>7</shortcut>
> </tool>
> 
> The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one.
> 
> 
> Diffs
> -----
> 
>   ui/pageviewannotator.cpp 7bd7496 
> 
> Diff: http://git.reviewboard.kde.org/r/109632/diff/
> 
> 
> Testing
> -------
> 
> While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change.
> I hope we can resume the discussion about possible improvements here.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130322/ea4517df/attachment.html>