[Okular-devel] Review Request 108614: Open url in browser

[Azat Khuzhin]

> On March 3, 2013, 4:47 p.m., Albert Astals Cid wrote:
> > This is still detecting "http://google.com)" as something you can call open link on. I'm not sure if "http://google.com)" is valid or not, but when you click on the "Go got 'http://google.com)'" I am getting a "Malformed URL" error. 
> > 
> > Can you please investigate if 'http://google.com)' is supposed to be a correct URL or not? If it is maybe you can try to find out why the "Malformed URL" error happens?

"http://google.com)" is not a valid URL.
Because host/port can't contain ")" and path must start from "/" see http://www.ietf.org/rfc/rfc3986.txt

Also I have a question, why you are using regular expression for this, I don't think that it is easy to write such regexp.
Why you don't just split by "[\t\n ]" and validate URL using qt/kde method? (I think qt/kde must have such)

But if there is no such, here is a good example of regexp for URL's - http://stackoverflow.com/a/190405
Also see note about "u" modifier.


- Azat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28459
-----------------------------------------------------------


On March 2, 2013, 10:39 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 10:39 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.
> 
> pdf with links update : http://goo.gl/wBM6p
> 
> 
> This addresses bug 281027.
>     http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> -------
> 
> just check if the icon appears properly, because I have an issue with the icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130303/94fbb1cd/attachment-0001.html>