<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108614/">http://git.reviewboard.kde.org/r/108614/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2013, 4:47 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is still detecting "http://google.com)" as something you can call open link on. I'm not sure if "http://google.com)" is valid or not, but when you click on the "Go got 'http://google.com)'" I am getting a "Malformed URL" error.
Can you please investigate if 'http://google.com)' is supposed to be a correct URL or not? If it is maybe you can try to find out why the "Malformed URL" error happens?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"http://google.com)" is not a valid URL.
Because host/port can't contain ")" and path must start from "/" see http://www.ietf.org/rfc/rfc3986.txt
Also I have a question, why you are using regular expression for this, I don't think that it is easy to write such regexp.
Why you don't just split by "[\t\n ]" and validate URL using qt/kde method? (I think qt/kde must have such)
But if there is no such, here is a good example of regexp for URL's - http://stackoverflow.com/a/190405
Also see note about "u" modifier.</pre>
<br />
<p>- Azat</p>
<br />
<p>On March 2nd, 2013, 10:39 p.m. UTC, Jaydeep Solanki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jaydeep Solanki.</div>
<p style="color: grey;"><i>Updated March 2, 2013, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.
pdf with links update : http://goo.gl/wBM6p</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just check if the icon appears properly, because I have an issue with the icon.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281027">281027</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/pageview.cpp <span style="color: grey">(b018dfe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108614/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>