[Okular-devel] Review Request 108614: Open url in browser

[Jaydeep Solanki]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
-----------------------------------------------------------

(Updated March 2, 2013, 10:33 p.m.)


Review request for Okular.


Changes
-------

I don't know why but after seeing the regex used by konversation I was convinced that it is a good idea, but now I thing it isn't.
Anyways, not detecting "xyz.com" will make it less error prone.
Updated.


Description
-------

When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.


This addresses bug 281027.
    http://bugs.kde.org/show_bug.cgi?id=281027


Diffs (updated)
-----

  ui/pageview.cpp b018dfe 

Diff: http://git.reviewboard.kde.org/r/108614/diff/


Testing
-------

just check if the icon appears properly, because I have an issue with the icon.


Thanks,

Jaydeep Solanki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130302/b7cff9a6/attachment.html>