[Okular-devel] Review Request 108614: Open url in browser

[Albert Astals Cid]

> On March 1, 2013, 6:33 p.m., Albert Astals Cid wrote:
> > Why the exceptions? Looks a bit weird to me.
> 
> Jaydeep Solanki wrote:
>     Please elaborate.

Why would you want to detect google.com) as a url?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28357
-----------------------------------------------------------


On Feb. 24, 2013, 1:55 a.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 1:55 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
>     http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> -------
> 
> just check if the icon appears properly, because I have an issue with the icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130302/0ee89c43/attachment.html>