[Okular-devel] Review Request 109633: Use crosshair cursor while annotating

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109633/#review34925
-----------------------------------------------------------


This review has been submitted with commit 09dad5e6d2124731166b75050a1bc8b4f038eee9 by Albert Astals Cid on behalf of Peter Grasch to branch master.

- Commit Hook


On June 17, 2013, 11:11 a.m., Peter Grasch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109633/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 11:11 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual "pen tip").
> 
> The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.h a9a291c 
>   ui/pageview.cpp 6567d5b 
>   ui/pageviewannotator.h 33e42a7 
>   ui/pageviewannotator.cpp d1d259e 
> 
> Diff: http://git.reviewboard.kde.org/r/109633/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully: Tool selection, deselection, continuous mode.
> 
> 
> Thanks,
> 
> Peter Grasch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130623/de58027f/attachment.html>