<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109633/">http://git.reviewboard.kde.org/r/109633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 09dad5e6d2124731166b75050a1bc8b4f038eee9 by Albert Astals Cid on behalf of Peter Grasch to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 17th, 2013, 11:11 a.m. UTC, Peter Grasch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Peter Grasch.</div>
<p style="color: grey;"><i>Updated June 17, 2013, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual "pen tip").
The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested successfully: Tool selection, deselection, continuous mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/pageview.h <span style="color: grey">(a9a291c)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(6567d5b)</span></li>
<li>ui/pageviewannotator.h <span style="color: grey">(33e42a7)</span></li>
<li>ui/pageviewannotator.cpp <span style="color: grey">(d1d259e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>