[Okular-devel] Review Request 109009: Txt backend for okular

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27680
-----------------------------------------------------------



generators/txt/document.cpp
<http://git.reviewboard.kde.org/r/109009/#comment20738>

    Please return QString(), returning "" calls an unnecessary number of constructors when QString() is as clear as "", same for the ::detectEncoding ""


- Albert Astals Cid


On Feb. 18, 2013, 5:03 p.m., Azat Khuzhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109009/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 5:03 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Simple txt backend for okular.
> 
> Development history:
> https://github.com/azat/okular/compare/master...add-txt-support
> 
> From mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -----
> 
>   generators/txt/generator_txt.cpp PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
>   generators/txt/okularApplication_txt.desktop PRE-CREATION 
>   generators/txt/okularTxt.desktop PRE-CREATION 
>   generators/CMakeLists.txt 5a101bf 
>   generators/txt/CMakeLists.txt PRE-CREATION 
>   generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
>   generators/txt/converter.h PRE-CREATION 
>   generators/txt/converter.cpp PRE-CREATION 
>   generators/txt/document.h PRE-CREATION 
>   generators/txt/document.cpp PRE-CREATION 
>   generators/txt/generator_txt.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109009/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130218/3f84187c/attachment.html>