<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109009/">http://git.reviewboard.kde.org/r/109009/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109009/diff/1/?file=114314#file114314line65" style="color: black; font-weight: bold; text-decoration: underline;">generators/txt/document.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">""</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please return QString(), returning "" calls an unnecessary number of constructors when QString() is as clear as "", same for the ::detectEncoding ""</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On February 18th, 2013, 5:03 p.m. UTC, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2013, 5:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple txt backend for okular.
Development history:
https://github.com/azat/okular/compare/master...add-txt-support
>From mailing list:
http://comments.gmane.org/gmane.comp.kde.devel.okular/13279</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/txt/generator_txt.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/libokularGenerator_txt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/okularApplication_txt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/okularTxt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/CMakeLists.txt <span style="color: grey">(5a101bf)</span></li>
<li>generators/txt/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/active-documentviewer_txt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/converter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/converter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/document.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/document.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/txt/generator_txt.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109009/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>