[Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests

Jon Mease jon.mease at gmail.com
Sat Apr 13 10:55:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109989/
-----------------------------------------------------------

Review request for Okular.


Description
-------

Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/)


This addresses bug 318091.
    http://bugs.kde.org/show_bug.cgi?id=318091


Diffs
-----

  tests/modifyannotationpropertiestest.cpp PRE-CREATION 
  tests/editannotationcontentstest.cpp PRE-CREATION 
  tests/addremoveannotationtest.cpp PRE-CREATION 
  core/page.cpp bb9ae83 
  tests/CMakeLists.txt 5d1ce2d 
  core/document.cpp 3302b76 
  tests/testingutils.h PRE-CREATION 
  tests/testingutils.cpp PRE-CREATION 
  tests/translateannotationtest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109989/diff/


Testing
-------

This is testing :-)


Thanks,

Jon Mease

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130413/363d64b7/attachment.html>


More information about the Okular-devel mailing list