[Okular-devel] Review Request: Extend GuiUtils with helper function for ScreenAnnotation
Albert Astals Cid
tsdgeos at terra.es
Sat Sep 29 14:10:00 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106607/#review19585
-----------------------------------------------------------
Ship it!
Works for me (once the other patches are commited)
- Albert Astals Cid
On Sept. 27, 2012, 1:48 p.m., Tobias Koenig wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106607/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2012, 1:48 p.m.)
>
>
> Review request for Okular.
>
>
> Description
> -------
>
> In a following patch we have to check inside PageView and PresentationWidget whether a ScreenAnnotation references a MediaRendition. To avoid code duplication and share the implementation, this patch adds a helper method to the GuiUtils namespace.
>
>
> Diffs
> -----
>
> ui/guiutils.h b68e211
> ui/guiutils.cpp 30be525
>
> Diff: http://git.reviewboard.kde.org/r/106607/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tobias Koenig
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120929/ed44edd6/attachment.html>
More information about the Okular-devel
mailing list