[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

[Bogdan Cristea]

> On Sept. 8, 2012, 1:46 p.m., Albert Astals Cid wrote:
> > okular.upd, line 5
> > <http://git.reviewboard.kde.org/r/104947/diff/5/?file=81331#file81331line5>
> >
> >     Seems, you are missing the mention of the old file here, no? http://techbase.kde.org/Development/Tools/Using_kconf_update#Example_update_file

Actually I want to keep the same settings file, otherwise if we decide to create a new settings file part.cpp line 295 needs to be modified too (see http://techbase.kde.org/Development/Tools/Using_kconf_update#File_format_of_the_update_file). However, the issue seems to be that all new keys are created in the settings file, even the ones that don't exist in the old settings. I found this behavior quite odd and I still don't know how to solve it.


- Bogdan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104947/#review18686
-----------------------------------------------------------


On Sept. 26, 2012, 8:25 p.m., Bogdan Cristea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104947/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 8:25 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
> -okular.kcfg (front end)
> -okular_core.kcfg (back end)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a057e82 
>   conf/okular.kcfg 9174733 
>   conf/okular_core.kcfg PRE-CREATION 
>   conf/settings.kcfgc 0b70390 
>   conf/settings_core.kcfgc PRE-CREATION 
>   core/document.cpp 7f006e6 
>   core/script/kjs_fullscreen.cpp c07ac4e 
>   core/texteditors_p.h 171dc69 
>   okular.upd PRE-CREATION 
>   ui/pagepainter.cpp 537e5c5 
>   ui/pageview.cpp 496abdc 
>   ui/presentationwidget.cpp 9ba942b 
> 
> Diff: http://git.reviewboard.kde.org/r/104947/diff/
> 
> 
> Testing
> -------
> 
> No
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120926/8a496b59/attachment.html>