[Okular-devel] Review Request: Comicbook: Simplify mimetype queries

[Albert Astals Cid]

> On March 4, 2012, 11:23 p.m., Albert Astals Cid wrote:
> > To be honest i don't like these changes at all
> > The .desktop files say
> >    MimeType=application/x-cbz;application/x-cbr;application/x-cbt;
> > and that is waht we should be checking for.

David are you there?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103941/#review11133
-----------------------------------------------------------


On Feb. 11, 2012, 5:59 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103941/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 5:59 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Simplify mimetype queries.
> 
> String comparisons are not recommended by KMimeType class. KMimeType::is() also hadles type inheritance. E.g.:
>   application/x-cbt inherits application/x-tar
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/document.cpp 3ba7483 
> 
> Diff: http://git.reviewboard.kde.org/r/103941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120908/cdc80b55/attachment.html>