[Okular-devel] Review Request: D-Bus access to non-first Okular::Part

Jaydeep Solanki jaydp17 at gmail.com
Sun Sep 23 11:53:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106531/
-----------------------------------------------------------

(Updated Sept. 23, 2012, 11:52 a.m.)


Review request for Okular.


Changes
-------

removed QSharedMemory, & used a static variable..
After this also, "okular_shellX" get's registered under "/okular", instead of it's respective "/okularX", else seems to be working...


Description
-------

This is just a rough change, I just want to confirm if I'm going in the right direction.
Once you confirm it, I'll clean up the code..

I guess it's not perfect, but manages to connect with the non first Okular::Part.


This addresses bug 306313.
    http://bugs.kde.org/show_bug.cgi?id=306313


Diffs (updated)
-----

  part.h 49607be 
  part.cpp fe11189 
  shell/main.cpp 226dab8 

Diff: http://git.reviewboard.kde.org/r/106531/diff/


Testing
-------


Thanks,

Jaydeep Solanki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120923/4f64dc4e/attachment.html>


More information about the Okular-devel mailing list