[Okular-devel] Review Request: D-Bus access to non-first Okular::Part

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106531/#review19340
-----------------------------------------------------------


Don't use the QSharedMemory, doesn't really bring us anything other than complexity. You can either just loop through registerObject seeing if it succeeds or not or if you think that is too ugly you can use a static variable that will keep track of the open parts.

- Albert Astals Cid


On Sept. 22, 2012, 5:41 p.m., Jaydeep Solanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106531/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2012, 5:41 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This is just a rough change, I just want to confirm if I'm going in the right direction.
> Once you confirm it, I'll clean up the code..
> 
> I guess it's not perfect, but manages to connect with the non first Okular::Part.
> 
> 
> This addresses bug 306313.
>     http://bugs.kde.org/show_bug.cgi?id=306313
> 
> 
> Diffs
> -----
> 
>   part.h 49607be 
>   part.cpp fe11189 
> 
> Diff: http://git.reviewboard.kde.org/r/106531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120922/02b43157/attachment.html>