[Okular-devel] Review Request: Activate additional actions of screen and widget annotations when entering/leaving a page

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106430/#review18918
-----------------------------------------------------------


I'm afraid that the more i think about what we did in poppler the less i like it, look at the api you are proposing and tell me, what's the difference between a ScreenAnnotation and a WidgetAnnotation, because they have exactly the same API :-S

- Albert Astals Cid


On Sept. 12, 2012, 7:30 a.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106430/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 7:30 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The latest LaTeX-movie package uses the additional action of an widget annotation (that does not belong to any form) to implement the auto-start feature of a video. Now that poppler provides access to the additional actions of annotations, this patch introduces the two new classes Okular::WidgetAnnotation and Okular::ScreenAnnotation, extends them with API to access the additional actions and fills the actions inside the poppler generator.
> 
> This patch fixes bug #300051
> 
> 
> This addresses bug 300051.
>     http://bugs.kde.org/show_bug.cgi?id=300051
> 
> 
> Diffs
> -----
> 
>   core/annotations.cpp ceb571c 
>   cmake/modules/FindPoppler.cmake 06e7117 
>   core/annotations.h e2b04bc 
>   generators/poppler/annots.cpp 06128c5 
>   generators/poppler/generator_pdf.cpp c63753e 
>   ui/guiutils.cpp f66dc47 
>   ui/presentationwidget.cpp 3f3796b 
> 
> Diff: http://git.reviewboard.kde.org/r/106430/diff/
> 
> 
> Testing
> -------
> 
> Tested with the PDF document that is attached to bug #300051.
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120912/16701748/attachment.html>