<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106430/">http://git.reviewboard.kde.org/r/106430/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm afraid that the more i think about what we did in poppler the less i like it, look at the api you are proposing and tell me, what's the difference between a ScreenAnnotation and a WidgetAnnotation, because they have exactly the same API :-S</pre>
<br />
<p>- Albert</p>
<br />
<p>On September 12th, 2012, 7:30 a.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2012, 7:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The latest LaTeX-movie package uses the additional action of an widget annotation (that does not belong to any form) to implement the auto-start feature of a video. Now that poppler provides access to the additional actions of annotations, this patch introduces the two new classes Okular::WidgetAnnotation and Okular::ScreenAnnotation, extends them with API to access the additional actions and fills the actions inside the poppler generator.
This patch fixes bug #300051</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the PDF document that is attached to bug #300051.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=300051">300051</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/annotations.cpp <span style="color: grey">(ceb571c)</span></li>
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(06e7117)</span></li>
<li>core/annotations.h <span style="color: grey">(e2b04bc)</span></li>
<li>generators/poppler/annots.cpp <span style="color: grey">(06128c5)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(c63753e)</span></li>
<li>ui/guiutils.cpp <span style="color: grey">(f66dc47)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(3f3796b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106430/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>