[Okular-devel] Review Request: Create proper Okular::ScreenAnnotation objects in poppler generator

[Christoph Feck]

> On Oct. 22, 2012, 11:06 a.m., Commit Hook wrote:
> > This review has been submitted with commit 77ccbbcbaae2eb8e93dc3a8852d754164477d538 by Tobias Koenig to branch master.

Causes compilation failure (poppler 0.21.0 is installed).

/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In function 'Okular::Action* createLinkFromPopplerLink(const Poppler::Link*)':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:293:44: error: 'const class Poppler::LinkRendition' has no member named 'action'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:295:22: error: 'NoRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:298:22: error: 'PlayRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:301:22: error: 'StopRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:304:22: error: 'PauseRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:307:22: error: 'ResumeRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:316:145: error: 'const class Poppler::LinkRendition' has no member named 'script'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In member function 'virtual Okular::FontInfo::List PDFGenerator::fontsForPage(int)':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:822:37: warning: 'bool Poppler::Document::scanForFonts(int, QList<Poppler::FontInfo>*) const' is deprecated (declared at /usr/include/poppler/qt4/poppler-qt4.h:1164) [-Wdeprecated-declarations]
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: At global scope:
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:1844:6: warning: unused parameter 'errorText' [-Wunused-parameter]
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In instantiation of 'void resolveMediaLinks(Okular::Action*, Okular::Annotation::SubType, QHash<Okular::Annotation*, Poppler::Annotation*>&) [with PopplerLinkType = Poppler::LinkRendition; OkularLinkType = Okular::RenditionAction; PopplerAnnotationType = Poppler::ScreenAnnotation; OkularAnnotationType = Okular::ScreenAnnotation]':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:985:179:   required from here
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:963:13: error: 'const class Poppler::LinkRendition' has no member named 'isReferencedAnnotation'
make[2]: *** [generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.o] Error 1
make[2]: Target `generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build' not remade because of errors.
make[1]: *** [generators/poppler/CMakeFiles/okularGenerator_poppler.dir/all] Error 2
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106605/#review20668
-----------------------------------------------------------


On Sept. 27, 2012, 1:41 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106605/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 1:41 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch requires the patch from https://bugs.freedesktop.org/show_bug.cgi?id=55378 to be comitted to poppler first.
> It creates proper Okular::ScreenAnnotation objects and setups their trigger action. Since a RenditionAction object can reference a ScreenAnnotation, the references are resolved the same way we did it for the MovieAction/MovieAnnotation pairs. So the resolveMovieLinkReference() method has been renamed to resolveMediaLinkReference() to match the functional change.
> 
> 
> Diffs
> -----
> 
>   generators/poppler/annots.cpp 02813a1 
>   generators/poppler/generator_pdf.h bea65d9 
>   generators/poppler/generator_pdf.cpp fcc8dc4 
> 
> Diff: http://git.reviewboard.kde.org/r/106605/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121025/f6dc0bf0/attachment.html>