<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106605/">http://git.reviewboard.kde.org/r/106605/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 22nd, 2012, 11:06 a.m., <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 77ccbbcbaae2eb8e93dc3a8852d754164477d538 by Tobias Koenig to branch master.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Causes compilation failure (poppler 0.21.0 is installed).
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In function 'Okular::Action* createLinkFromPopplerLink(const Poppler::Link*)':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:293:44: error: 'const class Poppler::LinkRendition' has no member named 'action'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:295:22: error: 'NoRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:298:22: error: 'PlayRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:301:22: error: 'StopRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:304:22: error: 'PauseRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:307:22: error: 'ResumeRendition' is not a member of 'Poppler::LinkRendition'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:316:145: error: 'const class Poppler::LinkRendition' has no member named 'script'
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In member function 'virtual Okular::FontInfo::List PDFGenerator::fontsForPage(int)':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:822:37: warning: 'bool Poppler::Document::scanForFonts(int, QList<Poppler::FontInfo>*) const' is deprecated (declared at /usr/include/poppler/qt4/poppler-qt4.h:1164) [-Wdeprecated-declarations]
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: At global scope:
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:1844:6: warning: unused parameter 'errorText' [-Wunused-parameter]
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp: In instantiation of 'void resolveMediaLinks(Okular::Action*, Okular::Annotation::SubType, QHash<Okular::Annotation*, Poppler::Annotation*>&) [with PopplerLinkType = Poppler::LinkRendition; OkularLinkType = Okular::RenditionAction; PopplerAnnotationType = Poppler::ScreenAnnotation; OkularAnnotationType = Okular::ScreenAnnotation]':
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:985:179: required from here
/local/git/KDE/graphics/okular/generators/poppler/generator_pdf.cpp:963:13: error: 'const class Poppler::LinkRendition' has no member named 'isReferencedAnnotation'
make[2]: *** [generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.o] Error 1
make[2]: Target `generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build' not remade because of errors.
make[1]: *** [generators/poppler/CMakeFiles/okularGenerator_poppler.dir/all] Error 2
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.
</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 27th, 2012, 1:41 p.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2012, 1:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch requires the patch from https://bugs.freedesktop.org/show_bug.cgi?id=55378 to be comitted to poppler first.
It creates proper Okular::ScreenAnnotation objects and setups their trigger action. Since a RenditionAction object can reference a ScreenAnnotation, the references are resolved the same way we did it for the MovieAction/MovieAnnotation pairs. So the resolveMovieLinkReference() method has been renamed to resolveMediaLinkReference() to match the functional change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/poppler/annots.cpp <span style="color: grey">(02813a1)</span></li>
<li>generators/poppler/generator_pdf.h <span style="color: grey">(bea65d9)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(fcc8dc4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106605/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>