[Okular-devel] Review Request: QML components and touch optimized okular version

Marco Martin notmart at gmail.com
Wed Oct 3 10:17:34 UTC 2012 


> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote:
> > You seem to be missing a Message.sh file
> 
> Marco Martin wrote:
>     i added a couple of messages.sh and catalogs.
>     org.kde.active.documentviewer.pot for the app, both qml and c++ parts
>     org.kde.okular.pot for the qml components: maybe that should be together okular.pot?
> 
> Albert Astals Cid wrote:
>     What maybe we should do is split okular into okularcore and regular "okular" application, but i think we can have that after we merge this stuff in.

+1 ;)


> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote:
> > active/app/package/contents/ui/Bookmarks.qml, line 5
> > <http://git.reviewboard.kde.org/r/106666/diff/1/?file=87953#file87953line5>
> >
> >     The chosen license looks a bit strage given all the rest of Okular code is just GPL, is this a conscious selection or just something that happened by c&p?
> 
> Marco Martin wrote:
>     i usually prefer lgpl for qml files to make it less of an hassle if some piece has to be moved in a component, but if here the preference is for gpl i can relicense it.
>     
>     btw i can see quite some problems if the okular core library is going to be used around
> 
> Albert Astals Cid wrote:
>     The problem is that if your qml files say LGPL, i can easy go and use them from a non free app and not realize i'm breaking the license.
>     
>     What do you mean with some problems?

my files are all gpl now.

since the rest of the kde libraries are lgpl there may be contexts (either proprietary or just opensource but incompatible licenses) where is possible to use any kde library but okularcore.

Probably the case of qml components (or the kpart) is a bit different since is loading a plugin at runtime rather than linking, but I don't know those legal technicalities :p


> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote:
> > active/components/documentitem.cpp, line 113
> > <http://git.reviewboard.kde.org/r/106666/diff/1/?file=87968#file87968line113>
> >
> >     Looks like we are losing some precision here by only returning the page number, no?
> 
> Marco Martin wrote:
>     yes.
>     it was kept simple since the ui only used that.
>     
>     it should get more complete (it has a page plus a qrect right?)
>     since qml can only understand qobjects, this should become either a list of qobjects, or probably a model, even just QStandardItemModel
> 
> Albert Astals Cid wrote:
>     It contains a Okular::DocumentViewport

i see the bookmarks have an url of the form
file:///home/diau/print.pdf#1;C2:0.499232:0.715558:1

is documented somewhere how to encode/decode that? i guess is possible to construct a DocumentViewport from that string?
maybe PageItem may have directly a viewport property that is a string encoded that way so from qml you would just pass that then the c++ side of PageItem parses and sets right page number and scroll value?


> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote:
> > active/app/active-documentviewer.desktop, line 13
> > <http://git.reviewboard.kde.org/r/106666/diff/1/?file=87952#file87952line13>
> >
> >     This is not correct, active-documentviewer will only support pdf if the poppler generator is built, you should probably imitate the billions of *.desktop files we have in the generators folders
> 
> Marco Martin wrote:
>     are they assembled in a single desktop file in the end?
>     what about generating a desktop file with the right mimetypes with cmake?
> 
> Albert Astals Cid wrote:
>     No, they are still different desktop files (one per mimetype), but kbuildsycoca knows how to handle that fine
>     Creating the desktop file from cmake seems ok too, but more work for my not so cmake able mind

may the desktop files be in the generators folder as well?
then the installation of the desktop file would be conditional if the active ui is built

or, if it may make easierto even split the desktop app in the future, it may have those desktop files in an own directory (then on a second moment the desktop app would change to a similar structure, if want to be splitted from core)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106666/#review19712
-----------------------------------------------------------


On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106666/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:17 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering)
> 
> Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a057e82 
>   active/CMakeLists.txt PRE-CREATION 
>   active/app/CMakeLists.txt PRE-CREATION 
>   active/app/Messages.sh PRE-CREATION 
>   active/app/active-documentviewer.desktop PRE-CREATION 
>   active/app/package/contents/ui/Bookmarks.qml PRE-CREATION 
>   active/app/package/contents/ui/Browser.qml PRE-CREATION 
>   active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION 
>   active/app/package/contents/ui/TableOfContents.qml PRE-CREATION 
>   active/app/package/contents/ui/Thumbnails.qml PRE-CREATION 
>   active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION 
>   active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION 
>   active/app/package/contents/ui/bookmark.png PRE-CREATION 
>   active/app/package/contents/ui/bookmark.svgz PRE-CREATION 
>   active/app/package/contents/ui/main.qml PRE-CREATION 
>   active/app/package/metadata.desktop PRE-CREATION 
>   active/app/src/CMakeLists.txt PRE-CREATION 
>   active/app/src/main.cpp PRE-CREATION 
>   active/components/CMakeLists.txt PRE-CREATION 
>   active/components/Messages.sh PRE-CREATION 
>   active/components/documentitem.h PRE-CREATION 
>   active/components/documentitem.cpp PRE-CREATION 
>   active/components/okularplugin.h PRE-CREATION 
>   active/components/okularplugin.cpp PRE-CREATION 
>   active/components/pageitem.h PRE-CREATION 
>   active/components/pageitem.cpp PRE-CREATION 
>   active/components/qmldir PRE-CREATION 
>   active/components/thumbnailitem.h PRE-CREATION 
>   active/components/thumbnailitem.cpp PRE-CREATION 
>   active/components/tocmodel.h PRE-CREATION 
>   active/components/tocmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121003/c03595d0/attachment-0001.html>

More information about the Okular-devel mailing list