<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106666/">http://git.reviewboard.kde.org/r/106666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2012, 7:54 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You seem to be missing a Message.sh file</pre>
</blockquote>
<p>On October 2nd, 2012, 12:19 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i added a couple of messages.sh and catalogs.
org.kde.active.documentviewer.pot for the app, both qml and c++ parts
org.kde.okular.pot for the qml components: maybe that should be together okular.pot?</pre>
</blockquote>
<p>On October 2nd, 2012, 6:09 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What maybe we should do is split okular into okularcore and regular "okular" application, but i think we can have that after we merge this stuff in.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1 ;)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2012, 7:54 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106666/diff/1/?file=87952#file87952line13" style="color: black; font-weight: bold; text-decoration: underline;">active/app/active-documentviewer.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">MimeType=application/vnd.kde.okular-archive;application/pdf;application/x-gzpdf;application/x-bzpdf;application/x-wwf;application/epub+zip;</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not correct, active-documentviewer will only support pdf if the poppler generator is built, you should probably imitate the billions of *.desktop files we have in the generators folders</pre>
</blockquote>
<p>On October 2nd, 2012, 12:19 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">are they assembled in a single desktop file in the end?
what about generating a desktop file with the right mimetypes with cmake?</pre>
</blockquote>
<p>On October 2nd, 2012, 6:05 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, they are still different desktop files (one per mimetype), but kbuildsycoca knows how to handle that fine
Creating the desktop file from cmake seems ok too, but more work for my not so cmake able mind</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">may the desktop files be in the generators folder as well?
then the installation of the desktop file would be conditional if the active ui is built
or, if it may make easierto even split the desktop app in the future, it may have those desktop files in an own directory (then on a second moment the desktop app would change to a similar structure, if want to be splitted from core)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2012, 7:54 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106666/diff/1/?file=87953#file87953line5" style="color: black; font-weight: bold; text-decoration: underline;">active/app/package/contents/ui/Bookmarks.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> * it under the terms of the GNU Library General Public License as</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The chosen license looks a bit strage given all the rest of Okular code is just GPL, is this a conscious selection or just something that happened by c&p?</pre>
</blockquote>
<p>On October 2nd, 2012, 12:19 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i usually prefer lgpl for qml files to make it less of an hassle if some piece has to be moved in a component, but if here the preference is for gpl i can relicense it.
btw i can see quite some problems if the okular core library is going to be used around</pre>
</blockquote>
<p>On October 2nd, 2012, 6:05 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem is that if your qml files say LGPL, i can easy go and use them from a non free app and not realize i'm breaking the license.
What do you mean with some problems?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">my files are all gpl now.
since the rest of the kde libraries are lgpl there may be contexts (either proprietary or just opensource but incompatible licenses) where is possible to use any kde library but okularcore.
Probably the case of qml components (or the kpart) is a bit different since is loading a plugin at runtime rather than linking, but I don't know those legal technicalities :p</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2012, 7:54 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106666/diff/1/?file=87968#file87968line113" style="color: black; font-weight: bold; text-decoration: underline;">active/components/documentitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<int> DocumentItem::bookmarks() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">113</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">list</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like we are losing some precision here by only returning the page number, no?</pre>
</blockquote>
<p>On October 2nd, 2012, 12:19 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes.
it was kept simple since the ui only used that.
it should get more complete (it has a page plus a qrect right?)
since qml can only understand qobjects, this should become either a list of qobjects, or probably a model, even just QStandardItemModel</pre>
</blockquote>
<p>On October 2nd, 2012, 6:05 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It contains a Okular::DocumentViewport </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i see the bookmarks have an url of the form
file:///home/diau/print.pdf#1;C2:0.499232:0.715558:1
is documented somewhere how to encode/decode that? i guess is possible to construct a DocumentViewport from that string?
maybe PageItem may have directly a viewport property that is a string encoded that way so from qml you would just pass that then the c++ side of PageItem parses and sets right page number and scroll value?</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 3rd, 2012, 10:17 a.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2012, 10:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering)
Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a057e82)</span></li>
<li>active/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/active-documentviewer.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Bookmarks.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Browser.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/FullScreenDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/TableOfContents.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Thumbnails.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/ThumbnailsBase.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/TreeDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/bookmark.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/bookmark.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/src/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/documentitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/documentitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/okularplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/okularplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/pageitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/pageitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/thumbnailitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/thumbnailitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/tocmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/tocmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>