[Okular-devel] Review Request: Activities support for Okular

Albert Astals Cid tsdgeos at terra.es
Tue Oct 2 18:13:51 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106685/#review19772
-----------------------------------------------------------


Any reason this is at the Document level and not at the Part level? Feels to me it belongs more into the part than the document.

- Albert Astals Cid


On Oct. 2, 2012, 4:15 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106685/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 4:15 p.m.)
> 
> 
> Review request for Okular, Plasma and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Okular reports the open/close document events to activity manager daemon.
> Side-effect - support for Share-Like-Connect applet.
> 
> (and some trailing spaces auto-removal)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a057e82 
>   core/document.cpp 143d598 
>   core/document_p.h 91a5577 
> 
> Diff: http://git.reviewboard.kde.org/r/106685/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121002/df67cc9c/attachment.html>


More information about the Okular-devel mailing list