[Okular-devel] Review Request: Activities support for Okular

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106685/
-----------------------------------------------------------

(Updated Oct. 2, 2012, 4:15 p.m.)


Review request for Okular, Plasma and Albert Astals Cid.


Changes
-------

Renamed the resource instance variable (resourceInstance -> activityResource) to match that one used in Gwenview.

"Outside of the domain of KActivities, "ResourceInstance" sounds too generic."
~ Aurélien Gâteau

Now, the remaining question is whether libkactivities should be mandatory as Aurelien requested in Gwenview:

"Make libkactivity a mandatory dependency. It is now widespread enough IMO and I prefer to avoid adding too many optional dependencies..."


Description
-------

Okular reports the open/close document events to activity manager daemon.
Side-effect - support for Share-Like-Connect applet.

(and some trailing spaces auto-removal)


Diffs (updated)
-----

  CMakeLists.txt a057e82 
  core/document.cpp 143d598 
  core/document_p.h 91a5577 

Diff: http://git.reviewboard.kde.org/r/106685/diff/


Testing
-------

yes


Thanks,

Ivan Čukić

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121002/212adea5/attachment-0001.html>