[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

Bogdan Cristea cristeab at gmail.com
Wed May 16 16:38:51 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 16, 2012, 4:38 p.m.)

Review request for Okular.


Full patch proposed for settings separation. 


Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
-okular.kcfg (front end)
-okular_core.kcfg (back end)

Diffs (updated)

  CMakeLists.txt 0034cf3 
  conf/okular.kcfg 6ad0e19 
  conf/okular_core.kcfg PRE-CREATION 
  conf/settings_core.kcfgc PRE-CREATION 
  core/document.cpp 0ebc34e 
  core/script/kjs_fullscreen.cpp c07ac4e 
  core/texteditors_p.h 171dc69 
  part.cpp 4c6aac8 
  ui/pagepainter.cpp ca55e81 
  ui/pageview.cpp 4be5e6b 
  ui/presentationwidget.cpp a3b8be4 

Diff: http://git.reviewboard.kde.org/r/104947/diff/




Bogdan Cristea

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120516/9c6c08b3/attachment.html>

More information about the Okular-devel mailing list