[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

[Albert Astals Cid]

> On May 15, 2012, 9:38 p.m., Albert Astals Cid wrote:
> > Why is EnableCompositing in core if it is only used in ui?
> 
> Bogdan Cristea wrote:
>     It belongs to "Dlg Performance" group, same as "MemoryLevel" entry which is used in core, because I have tried to keep groups intact. If that is ok, I could split the groups too, using as group name in the core something like "Core Performance" instead of "Dlg Performance". It seems to be rather easy to split everything if the respective entry is used or not in the core. 
>     
>     I'll submit another patch with these changes if you agree with splitting groups also.

Let's think about it for a second ok?

You are the user of a library, that library has a function called setEnableCompositing(bool enable);

And the documentation says "This function does nothing"

Not so cool eh? ;-)

Yes please split stuff that is used in the core vs stuff not used in the core.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104947/#review13868
-----------------------------------------------------------


On May 14, 2012, 5:29 p.m., Bogdan Cristea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104947/
> -----------------------------------------------------------
> 
> (Updated May 14, 2012, 5:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
> -okular.kcfg (front end)
> -okular_core.kcfg (back end)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0034cf3 
>   conf/okular.kcfg 6ad0e19 
>   conf/okular_core.kcfg PRE-CREATION 
>   conf/settings_core.kcfgc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104947/diff/
> 
> 
> Testing
> -------
> 
> No
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120515/ff94f699/attachment.html>