[Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

[Guillermo Antonio Amaral Bastidas]

> On March 20, 2012, 11:24 p.m., Albert Astals Cid wrote:
> > core/movie.h, line 48
> > <http://git.reviewboard.kde.org/r/104292/diff/2/?file=53396#file53396line48>
> >
> >     Should fileName have a different name? I mean it's not really a fileName is it?

It does show up as the original file name (and it's used as part of the tmp file name created from the data). But we can call it what ever you want ;)


- Guillermo Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104292/#review11671
-----------------------------------------------------------


On March 20, 2012, 11:35 p.m., Guillermo Antonio Amaral Bastidas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104292/
> -----------------------------------------------------------
> 
> (Updated March 20, 2012, 11:35 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Handles new Screen annotations in Poppler and displays using a Movie annotation.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPoppler.cmake 6b1ad66 
>   core/movie.h f4b64e1 
>   core/movie.cpp 8c7ffa5 
>   generators/poppler/annots.cpp 2944b64 
>   generators/poppler/config-okular-poppler.h.cmake 3f88d7f 
>   generators/poppler/generator_pdf.cpp 391d304 
>   ui/pageview.cpp 573d3e9 
> 
> Diff: http://git.reviewboard.kde.org/r/104292/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux (VLC and GStreamer phonon backends)
> 
> 
> Thanks,
> 
> Guillermo Antonio Amaral Bastidas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120320/75617f81/attachment.html>