[Okular-devel] Review Request: Allow PDF Generator to handle embedded movies

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104292/#review11671
-----------------------------------------------------------


Can we have a file to test with?


cmake/modules/FindPoppler.cmake
<http://git.reviewboard.kde.org/r/104292/#comment9269>

    Can you move it down so that we check for 0.12.1, then 0.16 and then 0.20? Don't think it makes any difference but makes more sense inside my head



cmake/modules/FindPoppler.cmake
<http://git.reviewboard.kde.org/r/104292/#comment9270>

    I'm pretty sure this gives you a cmake warning on line 109 (mismatched if/endif)



core/movie.h
<http://git.reviewboard.kde.org/r/104292/#comment9271>

    Should fileName have a different name? I mean it's not really a fileName is it?


- Albert Astals Cid


On March 20, 2012, 3:53 p.m., Guillermo Antonio Amaral Bastidas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104292/
> -----------------------------------------------------------
> 
> (Updated March 20, 2012, 3:53 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Handles new Screen annotations in Poppler and displays using a Movie annotation.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPoppler.cmake 6b1ad66 
>   core/movie.h f4b64e1 
>   core/movie.cpp 8c7ffa5 
>   generators/poppler/annots.cpp 2944b64 
>   generators/poppler/config-okular-poppler.h.cmake 3f88d7f 
>   generators/poppler/generator_pdf.cpp 391d304 
> 
> Diff: http://git.reviewboard.kde.org/r/104292/diff/
> 
> 
> Testing
> -------
> 
> Tested on Linux (VLC and GStreamer phonon backends)
> 
> 
> Thanks,
> 
> Guillermo Antonio Amaral Bastidas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120320/14eed5bd/attachment.html>