[Okular-devel] Review Request: Comicbook: Open 7z archives with The Unarchiver

[David Palacio]

> On Feb. 12, 2012, 9:58 p.m., Albert Astals Cid wrote:
> > Seems like lots of code of the unar.cpp is "copied" from unrar.cpp could you just generalize/share it? Having "duplicate" code is not good.

Right, my fault. My original intention is to remove the Rar classes and use only the Unarchiver. Please see Revision 2 of this review request. That still is my preference. For Okular to keep working as it does the cooperation of packagers is necessary. Do you think it is doable to have the unarchiver packaged in target/prefered distributions? What is your communication channel with Okular packagers?

If rev.2 is not acceptable, I will reduce the code duplication in this revision.

Thanks.


> On Feb. 12, 2012, 9:58 p.m., Albert Astals Cid wrote:
> > generators/comicbook/document.cpp, line 82
> > <http://git.reviewboard.kde.org/r/103942/diff/3/?file=49367#file49367line82>
> >
> >     is the 1.0 needed?

Version 0.99 of The Unarchiver is problematic so, I suggest to upgrade to 1.0 or later in this message.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103942/#review10567
-----------------------------------------------------------


On Feb. 12, 2012, 4:09 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103942/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 4:09 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This change adds support for 7z archives using "unar", the commandline decompressor from The Unarchiver[1].
> 
> This diff is based on the "Simplify mimetype queries" diff.
> 
> [1] http://wakaba.c3.cx/s/apps/unarchiver
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/CMakeLists.txt 067a07a 
>   generators/comicbook/document.h 22c3213 
>   generators/comicbook/document.cpp 3ba7483 
>   generators/comicbook/libokularGenerator_comicbook.desktop bec8c92 
>   generators/comicbook/okularApplication_comicbook.desktop 285f19d 
>   generators/comicbook/okularComicbook.desktop 4d70d70 
>   generators/comicbook/unar.h PRE-CREATION 
>   generators/comicbook/unar.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103942/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120303/25aca6c9/attachment-0001.html>