<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103942/">http://git.reviewboard.kde.org/r/103942/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 12th, 2012, 9:58 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems like lots of code of the unar.cpp is "copied" from unrar.cpp could you just generalize/share it? Having "duplicate" code is not good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right, my fault. My original intention is to remove the Rar classes and use only the Unarchiver. Please see Revision 2 of this review request. That still is my preference. For Okular to keep working as it does the cooperation of packagers is necessary. Do you think it is doable to have the unarchiver packaged in target/prefered distributions? What is your communication channel with Okular packagers?
If rev.2 is not acceptable, I will reduce the code duplication in this revision.
Thanks.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 12th, 2012, 9:58 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103942/diff/3/?file=49367#file49367line82" style="color: black; font-weight: bold; text-decoration: underline;">generators/comicbook/document.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Document::open( const QString &fileName )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mLastErrorString</span> <span class="o">=</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Cannot open document, unar 1.0 was not found."</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is the 1.0 needed?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Version 0.99 of The Unarchiver is problematic so, I suggest to upgrade to 1.0 or later in this message.</pre>
<br />
<p>- David</p>
<br />
<p>On February 12th, 2012, 4:09 p.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 4:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change adds support for 7z archives using "unar", the commandline decompressor from The Unarchiver[1].
This diff is based on the "Simplify mimetype queries" diff.
[1] http://wakaba.c3.cx/s/apps/unarchiver</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(067a07a)</span></li>
<li>generators/comicbook/document.h <span style="color: grey">(22c3213)</span></li>
<li>generators/comicbook/document.cpp <span style="color: grey">(3ba7483)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.desktop <span style="color: grey">(bec8c92)</span></li>
<li>generators/comicbook/okularApplication_comicbook.desktop <span style="color: grey">(285f19d)</span></li>
<li>generators/comicbook/okularComicbook.desktop <span style="color: grey">(4d70d70)</span></li>
<li>generators/comicbook/unar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/unar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>