[Okular-devel] Review Request: Comicbook: Open rar and 7z archives with The Unarchiver

[Harsh Chouraria J]

> On Feb. 11, 2012, 6:39 p.m., Harsh Chouraria J wrote:
> > Hi,
> > 
> > Nice changes.
> > 
> > Whats the uptake of the unar/lsar utils in distros? Are they available packaged in at least the two tiers of most popular used distributions?
> 
> David Palacio wrote:
>     The whohas utility reports that at least the following distributions package it today: Debian, Gentoo, Ubuntu.

We'd be indirectly crippling a lot of users' abilities to extract and read cbr (arguably the most dominant of the formats).

Can we perhaps have a fallback to Unrar until unar has more standardized acceptance/support across distributions?


> On Feb. 11, 2012, 6:39 p.m., Harsh Chouraria J wrote:
> > generators/comicbook/document.cpp, line 79
> > <http://git.reviewboard.kde.org/r/103942/diff/2/?file=49255#file49255line79>
> >
> >     Isn't there a chance for "unar"/"lsar" programs to not exist on a given distribution?
> >     
> >     We would need equivalent checks for the same.
> 
> David Palacio wrote:
>     The checks of rar right now are for the different decompressor versions that can be used. The case with The Unarchiver is a bit different. If unar/lsar are not installed the document will fail to open, as it does with rar/unrar. What it is missing right now is a helpful error message. If it fails to execute unar/lsar, it should give the user a hint to install the program.

If we can give the user a more direct hint to install a package that carries unar, I don't think we'd be doing any harm :-)


- Harsh Chouraria


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103942/#review10512
-----------------------------------------------------------


On Feb. 11, 2012, 6:02 p.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103942/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 6:02 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This change replaces the different rar archives decompressors with "unar", the commandline decompressor from The Unarchiver[1]. Support for 7z/cb7 archives is added as well.
> 
> This diff is based on the "Simplify mimetype queries" diff.
> 
> [1] http://wakaba.c3.cx/s/apps/unarchiver
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/CMakeLists.txt 067a07a 
>   generators/comicbook/document.h 22c3213 
>   generators/comicbook/document.cpp 3ba7483 
>   generators/comicbook/libokularGenerator_comicbook.desktop bec8c92 
>   generators/comicbook/okularApplication_comicbook.desktop 285f19d 
>   generators/comicbook/okularComicbook.desktop 4d70d70 
>   generators/comicbook/unar.h PRE-CREATION 
>   generators/comicbook/unar.cpp PRE-CREATION 
>   generators/comicbook/unrar.h d0fca3c 
>   generators/comicbook/unrar.cpp 27cc6af 
>   generators/comicbook/unrarflavours.h 974cd04 
>   generators/comicbook/unrarflavours.cpp 7451321 
> 
> Diff: http://git.reviewboard.kde.org/r/103942/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Palacio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120212/f1f7b206/attachment.html>