<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103942/">http://git.reviewboard.kde.org/r/103942/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2012, 6:39 p.m., <b>Harsh Chouraria J</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
Nice changes.
Whats the uptake of the unar/lsar utils in distros? Are they available packaged in at least the two tiers of most popular used distributions?</pre>
</blockquote>
<p>On February 11th, 2012, 7:33 p.m., <b>David Palacio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The whohas utility reports that at least the following distributions package it today: Debian, Gentoo, Ubuntu.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We'd be indirectly crippling a lot of users' abilities to extract and read cbr (arguably the most dominant of the formats).
Can we perhaps have a fallback to Unrar until unar has more standardized acceptance/support across distributions?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2012, 6:39 p.m., <b>Harsh Chouraria J</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103942/diff/2/?file=49255#file49255line79" style="color: black; font-weight: bold; text-decoration: underline;">generators/comicbook/document.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Document::open( const QString &fileName )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="o">!</span><span class="n">Unrar</span><span class="o">::</span><span class="n">isAvailable</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't there a chance for "unar"/"lsar" programs to not exist on a given distribution?
We would need equivalent checks for the same.</pre>
</blockquote>
<p>On February 11th, 2012, 7:33 p.m., <b>David Palacio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The checks of rar right now are for the different decompressor versions that can be used. The case with The Unarchiver is a bit different. If unar/lsar are not installed the document will fail to open, as it does with rar/unrar. What it is missing right now is a helpful error message. If it fails to execute unar/lsar, it should give the user a hint to install the program.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we can give the user a more direct hint to install a package that carries unar, I don't think we'd be doing any harm :-)</pre>
<br />
<p>- Harsh Chouraria</p>
<br />
<p>On February 11th, 2012, 6:02 p.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2012, 6:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change replaces the different rar archives decompressors with "unar", the commandline decompressor from The Unarchiver[1]. Support for 7z/cb7 archives is added as well.
This diff is based on the "Simplify mimetype queries" diff.
[1] http://wakaba.c3.cx/s/apps/unarchiver</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(067a07a)</span></li>
<li>generators/comicbook/document.h <span style="color: grey">(22c3213)</span></li>
<li>generators/comicbook/document.cpp <span style="color: grey">(3ba7483)</span></li>
<li>generators/comicbook/libokularGenerator_comicbook.desktop <span style="color: grey">(bec8c92)</span></li>
<li>generators/comicbook/okularApplication_comicbook.desktop <span style="color: grey">(285f19d)</span></li>
<li>generators/comicbook/okularComicbook.desktop <span style="color: grey">(4d70d70)</span></li>
<li>generators/comicbook/unar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/unar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/unrar.h <span style="color: grey">(d0fca3c)</span></li>
<li>generators/comicbook/unrar.cpp <span style="color: grey">(27cc6af)</span></li>
<li>generators/comicbook/unrarflavours.h <span style="color: grey">(974cd04)</span></li>
<li>generators/comicbook/unrarflavours.cpp <span style="color: grey">(7451321)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>