[Okular-devel] Review Request: Support multiple annotations in RMB menu

[Tobias Koenig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106035/
-----------------------------------------------------------

(Updated Aug. 15, 2012, 3:08 p.m.)


Review request for Okular.


Changes
-------

Using const char* / QString identifiers to avoid typos


Description
-------

If two annotations are placed on top of each other, clicking with the RMB on them will only show the menu entries for the top-most annotation.
This patch changes the behaviour by showing menu entries for all annotations that are located at that position.


Diffs (updated)
-----

  core/page.h a2571b7 
  core/page.cpp c778fe2 
  ui/annotationpopup.h e74284c 
  ui/annotationpopup.cpp 1c3a717 
  ui/pageview.cpp bcb4795 

Diff: http://git.reviewboard.kde.org/r/106035/diff/


Testing
-------

The patch fixes https://bugs.kde.org/show_bug.cgi?id=300942 and testing was done with the PDF attached to that bug report.


Thanks,

Tobias Koenig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120815/5d1839ab/attachment.html>