[Okular-devel] Review Request: Support multiple annotations in RMB menu

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106035/#review17449
-----------------------------------------------------------



ui/annotationpopup.cpp
<http://git.reviewboard.kde.org/r/106035/#comment13650>

    can you assign "actionType" and "open", "delete", "properties", "save" to static chars/Qstrings and use those variables instead of the chars directly so we don't make a typo somewhere and it stops working?


- Albert Astals Cid


On Aug. 15, 2012, 2:25 p.m., Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106035/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 2:25 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> If two annotations are placed on top of each other, clicking with the RMB on them will only show the menu entries for the top-most annotation.
> This patch changes the behaviour by showing menu entries for all annotations that are located at that position.
> 
> 
> Diffs
> -----
> 
>   core/page.h a2571b7 
>   core/page.cpp c778fe2 
>   ui/annotationpopup.h e74284c 
>   ui/annotationpopup.cpp 1c3a717 
>   ui/pageview.cpp bcb4795 
> 
> Diff: http://git.reviewboard.kde.org/r/106035/diff/
> 
> 
> Testing
> -------
> 
> The patch fixes https://bugs.kde.org/show_bug.cgi?id=300942 and testing was done with the PDF attached to that bug report.
> 
> 
> Thanks,
> 
> Tobias Koenig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120815/fbe507d0/attachment.html>