[Okular-devel] Review Request: Better next/previous page behaviour for facing pages

Albert Astals Cid tsdgeos at terra.es
Wed Apr 18 18:23:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104596/#review12638
-----------------------------------------------------------



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/104596/#comment9882>

    Please use viewColumns() instead calculating manually how many pages you have to jump


- Albert Astals Cid


On April 18, 2012, 5:56 p.m., Thomas Etter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104596/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 5:56 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> If two pages can be displayed at the same time while using a Facing mode, move two pages when pressing "next page" or "previous page".
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 4be5e6b 
> 
> Diff: http://git.reviewboard.kde.org/r/104596/diff/
> 
> 
> Testing
> -------
> 
> Works on my system
> 
> 
> Thanks,
> 
> Thomas Etter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20120418/8caccece/attachment-0001.html>


More information about the Okular-devel mailing list